-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Make swiping of plugins/sources less sensitive #1219
Conversation
#1199 |
Btw 62 is too much. It's cranky now. Can u try 35? |
I have tried 50 and it was still triggering the swipe, i think this would be quite hard to balance |
In ny opinion it's enough to lower the sensivity to |
It is currently hard coded but the best way is probably to turn it into a function of your phone's width |
I just tested with 35, seems fine to me. I hardly managed to get an unwanted trigger. Not sure on tablets. |
If you dont mind can i have your phone model |
In my opinion, we shouldn't adjust its value based on lower-end or older devices. If it's working well for most devices, that's sufficient. He uses a Huawei P8 Lite 2017. |
My device is very smooth when using plugin cards, it's not due to that because there is no lag, surprisingly. (yes that's my device) |
Ah its a misunderstanding i wanted to know your device so i can get the width and find a correlation |
1080x1920. Maybe a % value would be better? I am not sure if that value is a %, just saying. |
Tested on a Moto One 5G Ace, was able to get minor hitching when installing plugins, but nothing else. Tested on r1014. |
I have a painfully slow tablet I can test on as well if it would be helpful. However it barely runs a handful of Firefox tabs so I wouldn't say its indicative of the average low end device. |
Here is my data, I used an autoclicker with precise coordinates, Macrorify. Value 35 (minimum non-responsive swipe width: 65px or 9%) TYyBMmuU.mp4Value 62 (minimum non-responsive swipe width: 115px or 16%) i8SsPHen.mp4PS: if the extension opens it means the swipe failed to trigger the plugin card |
Practical test videos: YouCut_20240817_162216607.mp4Value 25↓ YouCut_20240817_162946545.mp4 |
The default value was 10(before this commit). Three times it reduces the problems by 90%. |
Ok that sounds like a good compromise, pretty unrealistic to expect no triggers |
Make swiping source/plugins less sensitive, related issue #1199
video_2024-08-17_17-33-34.mp4